Repository navigation
fix(game): SC layouts the 1.2 client reads differently (criminal arrested, tower def list, play sound) - #41
Merged
Conversation
…sted, tower def list, play sound) - SCCriminalArrested: the criminal's obj id is a 3-byte bc (x2game 397b6870), not a u32. - SCTowerDefList: the count is a u8 and the client reads at most 100 entries (397caad0). - SCPlaySound: the NPC of a kind-2 (bubble) cue is a bc (397bea30), not a u32. Each extra byte shifted the following fields, so the client read garbage names / ids. Co-Authored-By: Claude Opus 5.5 <[email protected]>
Coverage Report for CI Build 39980529139Warning No base build found for commit Coverage: 76.698%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsRequires a base build to compare against. How to fix this → Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three SC packets the lane writes with a layout the 1.2 client reads differently (checked against the client's readers in x2game.dll):
SCCriminalArrestedu32 criminalObjIdbc(397b6870)SCTowerDefListi32 countu8 count, at most 100 entries (397caad0)SCPlaySound(kind 2)u32 npcObjIdbc(397bea30)The extra bytes shifted the fields after them, so the client showed garbage names / ids. Byte tests updated;
cargo test -p aaemu-game tower_def trial play_soundpasses.Found while decoding these packets in the Bevy client (AABevy1.2, aa-net
notice.rs).🤖 Generated with Claude Code